Skip to content

Please cherry pick fix for issue 28610 into the 1.22.0.dev #28627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Feb 3, 2017 · 3 comments
Closed

Please cherry pick fix for issue 28610 into the 1.22.0.dev #28627

a-siva opened this issue Feb 3, 2017 · 3 comments
Assignees
Milestone

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 3, 2017

Please cherry pick fix for #28610 into the 1.22.0.dev branch
The Cl that fixes it is 1ff4a5a

@a-siva a-siva added this to the 1.22 milestone Feb 3, 2017
@whesse
Copy link
Contributor

whesse commented Feb 6, 2017

This cherry-pick does not merge. It depends on the the commit 97f968d
which is not in 1.22 because it was landed after the last full push to dev.

Either this fix is not needed, because teh issue was introduced by that prior CL, or that prior CL needs to be cherry-picked as well to 1.22.

@eernstg
Copy link
Member

eernstg commented Feb 6, 2017

I believe this was settled in #28610: The whole generic function type syntax feature is at milestone 1.23; in 1.22 we only deprecate certain usages of the identifier Function, such that we will have fewer update conflicts when this syntax is introduced.

@a-siva
Copy link
Contributor Author

a-siva commented Feb 6, 2017

Sorry my bad I was under the impression that it went into 1.22. will close this issue.

@a-siva a-siva closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants