Move DDC to using the new analysis driver

[scheglov]

The current status for running DDC presubmit checks:

01:11 +4985 -3: Some tests failed.

[jmesserly]

what are the 3 tests, out of curiosity? could it be expected failures because the inference behavior changed (per the new spec)?

[scheglov]

Analysis Server crashes (I think with stack overflow) in:

codegen dartdevc language/covariant_override/tear_off_type_test
codegen dartdevc language/cyclic_typedef_test_10_multi
codegen dartdevc language/cyclic_typedef_test_11_multi

For example on this:

typedef A<T extends A>();

What is expected to happen here at all?
I find it hard to track all the informal specification changes floating around.

[jmesserly]

it's supposed to be a compile time error, right?

[scheglov]

Yes, I think so.

[dgrove]

any updates on this?

[scheglov]

No new work was done since a week ago :-(
I'm still working on top-level type inference, which turned out to be much bigger than I initially anticipated.

[bwilkerson]

Does this still need to be done for 1.23?

[scheglov]

No, it doesn't.
I planned to do this, so put it preliminary into the closest version, but was not able to finish it yet.

[dgrove]

Any updates here? Happening for 1.23?

[scheglov]

The CL is out for review.
But there is one issue where I need help from DDC people..

[jmesserly]

Oh gosh, my bad! I've replied there @scheglov ... and I just want to say here, the change looks lovely, thanks for putting so much work into making it such an elegant patch.

[vsmenon]

What's the status of this? Ready for 1.24? If not, do we need it?

[jmesserly]

I sent a patch to @scheglov to fix the CL. I'm not sure however if it's correct in general. There seems to be a behavior change for custom URL mappings. However it does fix async_helper to compile despite that.

[scheglov]

Thank you.
This improves the situation with tests.
But there are still 21 tests failing, and I don't know whether I qualify to perform initial triage of these tests.

browser_tests_fail_20170510.txt

[dgrove]

@vsmenon is this happening for 1.24?

[jmesserly]

Current theory is we won't need to do this, because DDC will migrate to Kernel. But if we see problems with the current DDC approach, we should revisit this.