Skip to content

Suggestions on the "Import library" fixes from dart analysis server #29877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yyoon opened this issue Jun 14, 2017 · 1 comment
Closed

Suggestions on the "Import library" fixes from dart analysis server #29877

yyoon opened this issue Jun 14, 2017 · 1 comment
Labels
devexp-server Issues related to some aspect of the analysis server devexp-ux legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@yyoon
Copy link
Contributor

yyoon commented Jun 14, 2017

(originally filed at Dart-Code/Dart-Code#320)

The "Import library" code fix is useful, but could be improved in a few ways.

  • If the import declarations are already sorted, insert the new import in the right place. For now I have to import and then sort as a two step process.
  • If the file being imported is in the current package, please consider offering the relative path import as an option.
  • Also please consider offering an option to import the desired library with show Foo at the end. For instance, we do import 'dart:convert' show JSON; a lot in our project.
@dgrove dgrove added devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. labels Jun 15, 2017
@bwilkerson bwilkerson added devexp-ux P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Jun 19, 2017
@srawlins
Copy link
Member

srawlins commented Jan 5, 2022

The first two items are now implemented.

The third is tracked at #32234.

@srawlins srawlins closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-server Issues related to some aspect of the analysis server devexp-ux legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants