Skip to content

Fix uses of fuzzy arrows in pkg/front_end and re-enable hint. #30590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leafpetersen opened this issue Aug 31, 2017 · 1 comment
Closed

Fix uses of fuzzy arrows in pkg/front_end and re-enable hint. #30590

leafpetersen opened this issue Aug 31, 2017 · 1 comment
Assignees
@leafpetersen
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@leafpetersen
Copy link
Member

The treatment of dynamic as bottom when it occurs in the argument position of a function type is being deprecated and removed in Dart 2.0. I am adding a hint to warn on uses of this, and will land a CL disabling this hint in the pkg/front_end analysis_options.yaml.

The line uses_dynamic_as_bottom: ignore should be removed from /pkg/front_end/analysis_options.yaml once the code as been fixed up appropriately.
@leafpetersen leafpetersen added the legacy-area-front-end Legacy: Use area-dart-model instead. label Aug 31, 2017
@leafpetersen leafpetersen mentioned this issue Oct 3, 2017
Closed
@leafpetersen
Copy link
Member Author

This is becoming blocking on #29630 since pkg/front_end is depended on by internal google code.

@leafpetersen leafpetersen mentioned this issue Oct 3, 2017
Closed
@leafpetersen leafpetersen self-assigned this Oct 19, 2017
@whesse whesse closed this as completed in 4270b99 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafpetersen leafpetersen

Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leafpetersen