Parse getter with the same name of the enclosing class

[scheglov]

class A {
  get A => 0;
}

library;
import self as self;
import "dart:core" as core;

class A extends core::Object {
  constructor •() → void
    : super core::Object::•()
    const core::_ConstantExpressionError::•()._throw(new core::_CompileTimeError::•("file:///test.dart:2:12: Error: Can't return from a constructor.\n  get A => 0;\n           ^"));
}

The produced Kernel does not correspond to the original Dart code.

[peter-ahe-google]

Interesting. Fasta doesn't even report an error if I change it to this:

class A {
  get A {
    print("Actually, I'm a getter, not a constructor.");
  }
}

main() {
  new A();
}

library;
import self as self;
import "dart:core" as core;

class A extends core::Object {
  constructor •() → void
    : super core::Object::•() {
    core::print("Actually, I'm a getter, not a constructor.");
  }
}
static method main() → dynamic {
  new self::A::•();
}

[peter-ahe-google]

Let me know if this is blocking you.

[bwilkerson]

I believe that this fixes the AstBuilder (https://dart-review.googlesource.com/c/sdk/+/25580). I've started looking at kernel, but don't know whether I'll have any success and don't mind having someone else look at it.

[bwilkerson]

@peter-ahe-google I made some changes (https://dart-review.googlesource.com/c/sdk/+/25600) but there was no change in the test status, which either means that my changes didn't have the intended effect or that there are no tests for this case. Advice would be appreciated.

[peter-ahe-google]

@bwilkerson I would add the above examples to pkg/front_end/testcases.

Also, @askeksa-google is working on a similar bug. See #30834 and https://dart-review.googlesource.com/c/sdk/+/34120

[peter-ahe-google]

Also #31299

[askeksa-google]

After https://dart-review.googlesource.com/c/sdk/+/34120 the code now produces a getter properly, plus a synthetic constructor. Can this issue be closed?

[peter-ahe-google]

I'd be most comfortable closing this bug after we've added a regression test corresponding to the getter from my example.