Skip to content

Improve testing of generic functions #31219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjindel-google opened this issue Oct 25, 2017 · 6 comments
Closed

Improve testing of generic functions #31219

sjindel-google opened this issue Oct 25, 2017 · 6 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-fasta

Comments

@sjindel-google
Copy link
Contributor

Generic functions are not well tested, as evidenced by the recent discovery of #31213.
We should add more tests that for generic functions, methods and function types, to improve coverage
esp. in Fasta and the nascent generic functions support in the VM.

@sjindel-google sjindel-google added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-fasta labels Oct 25, 2017
@a-siva
Copy link
Contributor

a-siva commented Oct 26, 2017

The plan was to see if we could get the co19 folks to write more comprehensive tests for generic functions and strong mode.
/cc @anders-sandholm

@matanlurey
Copy link
Contributor

matanlurey commented Oct 26, 2017

Is there any reason the language team can't write tests for their own language features?

See #30761 - there were/are lots of issues.

@anders-sandholm anders-sandholm added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Oct 26, 2017
@anders-sandholm
Copy link
Contributor

@a-siva thanks for looping me in.

Yes, we are planning on expanding co19, the Dart language conformance test suite, to cover 2.0 and hence also strong mode and generic functions. I filed #31229 for tracking this.

While expanding the conformance test suite will help, it will most likely not remove the need for implementation-specific tests as well for e.g. generic functions. Ideally, DDC would already have a bunch of these tests given that is was developed along side the definition of strong mode. But there will likely be other tests that are specific to the Analyzer, the VM, etc.

That said, I look forward to having the full spec and conformance tests in place.

@a-siva
Copy link
Contributor

a-siva commented Nov 9, 2017

Who should own this bug? I would like to add a milestone of 2.0-beta1 for this bug

@anders-sandholm
Copy link
Contributor

I'd suggest someone on the VM team own it, if the bug is about adding more tests that are specific to the VM or close it if you believe it is covered by the more general #31229.

@a-siva
Copy link
Contributor

a-siva commented Nov 10, 2017

I think you have covered it well in #31229, will close this.

@a-siva a-siva closed this as completed Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-fasta
Projects
None yet
Development

No branches or pull requests

4 participants