analyzer co19_2 test failures when switching the parser to fasta

[devoncarew]

@danrubel

[bwilkerson]

Are there test failures that need to be tracked here, or can we close this?

[devoncarew]

I see 60 references from co19_2/co19_2-analyzer.status.

[danrubel]

Fixes:

• https://dart-review.googlesource.com/c/sdk/+/74523
• https://dart-review.googlesource.com/c/sdk/+/74601
• https://dart-review.googlesource.com/c/sdk/+/74680

Open issues outside fasta parser and AstBuilder:

• An overriding method can't specify a different default value An overriding method can't specify a different default value #34437
• Compilation error in co19 async loop tests Compilation error in co19 async loop tests #34438
• Invalid co19 enum test Invalid co19 enum test #34440

Pre existing issues:

• Missing override errors on name collisions and default values Missing override errors on name collisions and default values #27476
• Static getter or setter declaration doesn't add an instance one to the Type object Static getter or setter declaration doesn't add an instance one to the Type object #23721
• Analyzer throws error when try to assign a function result to row variable Analyzer throws error when try to assign a function result to row variable. #33805
• Dartanalyzer 2.0 incorrectly throws type_argument_not_matching_bounds error for super-bounded types in preview-dart-2 mode Dartanalyzer 2.0 incorrectly throws type_argument_not_matching_bounds error for super-bounded types in preview-dart-2 mode #32903
• Analyzer throws exception if function optional argument is omitted and it's parametrized Analyzer throws exception if function optional argument is omitted and it's parametrized. #33864
• Dartanalyzer does not throw compiler error when function variable with incorrect return type parameter is declared Dartanalyzer does not throw compiler error when function variable with incorrect return type parameter is declared #33597
• CFE doesn't check type arguments against the bounds of the corresponding type variables CFE doesn't check type arguments against the bounds of the corresponding type variables #33308

[danrubel]

I have fixed what I can in the parser (see above) and many (all?) of the rest are pre-existing issues. If you do find another parser or AstBuilder related issue, please let me know

[devoncarew]

Great! I'll close this now given that the remaining issues are pre-existing.