Skip to content

unecessary_cast false-positive #35140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Nov 12, 2018 · 3 comments
Closed

unecessary_cast false-positive #35140

pq opened this issue Nov 12, 2018 · 3 comments
Labels
devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@pq
Copy link
Member

pq commented Nov 12, 2018

From @zoechi on November 11, 2018 16:11

  @override
  BuiltList<Node> get childNodes =>
      (ListBuilder<Node>(directives as Iterable ?? <Node>[])
            ..addAll(selections))
          .build();

  @nullable
  BuiltList<Directive> get directives;

  BuiltList<Selection> get selections;

Directive and Selection implement Node

image

image

Copied from original issue: dart-lang/linter#1260
@pq
Copy link
Member Author

pq commented Nov 12, 2018

This is actually an analyzer hint and should be tracked in the SDK...

@pq pq mentioned this issue Nov 12, 2018
Closed
@pq pq added legacy-area-analyzer Use area-devexp instead. devexp-warning Issues with the analyzer's Warning codes labels Nov 12, 2018
@pq
Copy link
Member Author

pq commented Nov 12, 2018

/cc @bwilkerson

@stereotype441 stereotype441 added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 13, 2018
@srawlins
Copy link
Member

Looks like a duplicate of #34150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @stereotype441