Skip to content

Add SSL support for HttpServer and HttpClient on VM #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sethladd opened this issue Jun 13, 2012 · 19 comments
Closed

Add SSL support for HttpServer and HttpClient on VM #3593

sethladd opened this issue Jun 13, 2012 · 19 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P0 A serious issue requiring immediate resolution type-enhancement A request for a change that isn't a bug
Milestone

Comments

@sethladd
Copy link
Contributor

The Dart VM does not support SSL connections. SSL is very popular for modern web services, like the Amazon web services. It would be nice to use Dart to connect to and control AWS services.

@sethladd
Copy link
Contributor Author

@sgjesse
Copy link
Contributor

sgjesse commented Jul 2, 2012

Marked this as being blocked by #3950.

@whesse
Copy link
Contributor

whesse commented Jul 5, 2012

This bug is for SSL support in HttpServer and HttpClient. It is blocked on SSL support in Socket and ServerSocket, which needs to be there first.


Set owner to @whesse.
Added this to the M1 milestone.
Removed Type-Defect, Priority-Medium labels.
Added Type-Enhancement, Priority-High, Accepted labels.

@whesse
Copy link
Contributor

whesse commented Jul 5, 2012

Issue #2678 has been merged into this issue.


cc @madsager.

@DartBot
Copy link

DartBot commented Jul 25, 2012

This comment was originally written by [email protected]


I just wanted to comment to let you know that not having HTTPS was a show-stopper for a project my company just undertook. We were willing to experiment with Dart because of its promising future, but HTTPS is critical for this project. Had to go with another language.

@jmesserly
Copy link

Marked this as blocking #5191.

@madsager
Copy link
Contributor

madsager commented Oct 1, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@munificent
Copy link
Member

Note that since pub uses dart:io, this is prevents pub from using HTTPS to download packages.

@madsager
Copy link
Contributor

madsager commented Oct 3, 2012

This is in active development. We have changed directions a couple of times, but Bill is getting close with a solution that will share code across all three platforms. Changing the status of the bug to started to reflect the fact that the work is well under way.


Added Started label.

@munificent
Copy link
Member

Awesome!

@sgjesse
Copy link
Contributor

sgjesse commented Oct 12, 2012

Marked this as blocking #5468.

@DartBot
Copy link

DartBot commented Oct 28, 2012

This comment was originally written by [email protected]


Will this fix also allow for secure websockets on the client and server?

@sgjesse
Copy link
Contributor

sgjesse commented Oct 29, 2012

When HTTPS is supported secure websockets will also be supported as the websocket protocol is an upgrade of an already established HTTP/HTTPS connection.

@nex3
Copy link
Member

nex3 commented Oct 31, 2012

This is critical for user-accessible package uploads for pub. The command-line pub client needs to use OAuth2 to authenticate with the server, which requires the use of HTTPS.


Removed Priority-High label.
Added Priority-Critical label.

@nex3
Copy link
Member

nex3 commented Oct 31, 2012

Marked this as blocking #6177.

@madsager
Copy link
Contributor

madsager commented Nov 1, 2012

Work is in progress on this. It is taking longer than anticipated but we are having the initial code reviews for the client side out for review now. It will probably take a little while (a couple of weeks at least) before this is ready for use.

@nex3
Copy link
Member

nex3 commented Nov 26, 2012

Unmarked this as blocking #6177.

@whesse
Copy link
Contributor

whesse commented Nov 30, 2012

This has been committed in r15452 and r15450. Examples of how to use them are in tests/standalone/io/https_client_test.dart and https_server_test.dart.
An upcoming change will allow SecureSocket.initialize() (renamed from SecureSocket.setCertificateDatabase(String database)) to omit the database argument,
and rely on the built-in root certificates.


Added Fixed label.

@sgjesse
Copy link
Contributor

sgjesse commented Dec 12, 2012

Unmarked this as blocking #5468.

@sethladd sethladd added Type-Enhancement P0 A serious issue requiring immediate resolution area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels Dec 12, 2012
@sethladd sethladd added this to the M2 milestone Dec 12, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P0 A serious issue requiring immediate resolution type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

9 participants