Skip to content

Analyzer should warn when using UI as code features with an SDK constraint that does not guarantee support #36046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stereotype441 opened this issue Feb 26, 2019 · 6 comments
Closed

Analyzer should warn when using UI as code features with an SDK constraint that does not guarantee support #36046

stereotype441 opened this issue Feb 26, 2019 · 6 comments
Assignees
@bwilkerson
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone
Dart 2.3

Comments

@stereotype441
Copy link
Member

Similar to #36024 but for the "UI as code" feature
@stereotype441 stereotype441 added legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Feb 26, 2019
@stereotype441
Copy link
Member Author

The latest information I have from the Dart scrum team is that the first version of Dart with "UI as code" features enabled will be 2.2.2, so we should implement the warning so that it fires if the user's SDK constraint includes versions prior to 2.2.2.

If we change our minds and decide to ship 2.2.2 without "UI as code" features enabled by default, we can update the warning accordingly before doing so.

@bwilkerson
Copy link
Member

https://dart-review.googlesource.com/c/sdk/+/96837

@stereotype441
Copy link
Member Author

Fix was reverted in 0f4a208

@stereotype441 stereotype441 reopened this Mar 19, 2019
This was referenced Mar 19, 2019
Closed
Closed
@JekCharlsonYu JekCharlsonYu mentioned this issue Mar 20, 2019
Closed
15 tasks
@stereotype441 stereotype441 added this to the Dart2.3 milestone Mar 21, 2019
@stereotype441
Copy link
Member Author

Fix was re-landed in 495c319

@bwilkerson
Copy link
Member

This issue being closed only means that when the experiment is enabled that analyzer will tell users if their SDK constraints are not high enough. The experiment is not enabled by default in analyzer; that will happen when it happens everywhere else.

@lrhn
Copy link
Member

lrhn commented Mar 21, 2019

Ah, makes sense. Carry on! :)

@srawlins srawlins mentioned this issue Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Dart 2.3
Development

No branches or pull requests
3 participants
@stereotype441 @lrhn @bwilkerson