-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support for extension methods in dartdoc #39049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mit-mit I assume you mean "Document" extension methods rather than "Dartpad"? |
Sorry, bad copy-paste |
dartdoc 0.29.0 is coming in time for D27, and it will have the fix for dart-lang/dartdoc#2032. A partial fix for dart-lang/dartdoc#2021 should also land in time (dart-lang/dartdoc#2053). |
Any update here? |
Ping. Is there an update on what landed? (At least one of the unchecked issues in the first comment is now closed.) Is there anything in flight that merits cherry-picking? |
Also, have we pinned the latest dartdoc in Dart and Flutter DEPS? |
Fixes for dart-lang/dartdoc#2032 and dart-lang/dartdoc#2047, and a partial fix for dart-lang/dartdoc#2021 have landed and are pinned in Dart and Flutter. I consider this a bare-minimum level of support for extension methods, and am currently focusing on NNBD support in Dartdoc before improving extension methods further. |
Clearing milestone now that the must-do work for 2.7 is fine |
Where are we tracking the roll to a working version of dartdoc on the pub site? |
looks like dart-lang/pub-dev#3088 |
Uh oh!
There was an error while loading. Please reload this page.
@jcollins-g what's remaining here? Can you link this to more detailed issues for what has to get done?
(by @jcollins-g) :
Extension methods, due to the significant change in Dart scoping rules, has a huge impact on Dartdoc that wasn't originally anticipated. The main issues are listed below:
Some changes to the analyzer to provide more data so Dartdoc can discover extension methods in the reexport case are also needed for dartdoc to be correct on all edge cases.
The text was updated successfully, but these errors were encountered: