Skip to content

Support for extension methods in dartdoc #39049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks done
mit-mit opened this issue Oct 22, 2019 · 10 comments
Open
4 tasks done

Support for extension methods in dartdoc #39049

mit-mit opened this issue Oct 22, 2019 · 10 comments
Assignees
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).

Comments

@mit-mit
Copy link
Member

mit-mit commented Oct 22, 2019

@jcollins-g what's remaining here? Can you link this to more detailed issues for what has to get done?


(by @jcollins-g) :

Extension methods, due to the significant change in Dart scoping rules, has a huge impact on Dartdoc that wasn't originally anticipated. The main issues are listed below:

Some changes to the analyzer to provide more data so Dartdoc can discover extension methods in the reexport case are also needed for dartdoc to be correct on all edge cases.

@mit-mit mit-mit added this to the D27 Release milestone Oct 22, 2019
@jcollins-g
Copy link
Contributor

@mit-mit I assume you mean "Document" extension methods rather than "Dartpad"?

@mit-mit mit-mit changed the title Dartpad extension methods in dartdoc Support for extension methods in dartdoc Oct 22, 2019
@mit-mit
Copy link
Member Author

mit-mit commented Oct 22, 2019

Sorry, bad copy-paste

@mit-mit mit-mit added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Oct 23, 2019
@jcollins-g
Copy link
Contributor

dartdoc 0.29.0 is coming in time for D27, and it will have the fix for dart-lang/dartdoc#2032. A partial fix for dart-lang/dartdoc#2021 should also land in time (dart-lang/dartdoc#2053).

@vsmenon
Copy link
Member

vsmenon commented Nov 5, 2019

Any update here?

@vsmenon
Copy link
Member

vsmenon commented Nov 12, 2019

Ping. Is there an update on what landed? (At least one of the unchecked issues in the first comment is now closed.)

Is there anything in flight that merits cherry-picking?

@vsmenon
Copy link
Member

vsmenon commented Nov 12, 2019

Also, have we pinned the latest dartdoc in Dart and Flutter DEPS?

@jcollins-g
Copy link
Contributor

Fixes for dart-lang/dartdoc#2032 and dart-lang/dartdoc#2047, and a partial fix for dart-lang/dartdoc#2021 have landed and are pinned in Dart and Flutter.

I consider this a bare-minimum level of support for extension methods, and am currently focusing on NNBD support in Dartdoc before improving extension methods further.

@mit-mit
Copy link
Member Author

mit-mit commented Nov 14, 2019

Clearing milestone now that the must-do work for 2.7 is fine

@mit-mit mit-mit removed this from the D27 Release milestone Nov 14, 2019
@natebosch
Copy link
Member

Where are we tracking the roll to a working version of dartdoc on the pub site?

@jcollins-g
Copy link
Contributor

looks like dart-lang/pub-dev#3088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).
Projects
None yet
Development

No branches or pull requests

4 participants