Skip to content

DDC should throw TypeErrorImpl for both cast and type errors #41008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leafpetersen opened this issue Mar 12, 2020 · 0 comments
Closed

DDC should throw TypeErrorImpl for both cast and type errors #41008

leafpetersen opened this issue Mar 12, 2020 · 0 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-dev-compiler

Comments

@leafpetersen
Copy link
Member

Per #40763, I landed the change to make the ddc implementation classes TypeErrorImpl and CastErrorImpl both implement TypeError and CastError here.

CastError will be deprecated in a follow up CL. The web compilers should be changed to throw instances of a single implementation class (TypeErrorImpl) for all implicit and explicit casts. This change should be non-breaking given the changes in my CL.

cc @sigmundch @rakudrama @fishythefish @nshahan
@leafpetersen leafpetersen added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop label Mar 12, 2020
@nshahan nshahan self-assigned this Mar 12, 2020
@nshahan nshahan mentioned this issue Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundch @nshahan @leafpetersen