Skip to content

Test failures due to breaking change 40678 #41068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnniwinther opened this issue Mar 17, 2020 · 3 comments
Closed

Test failures due to breaking change 40678 #41068

johnniwinther opened this issue Mar 17, 2020 · 3 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@johnniwinther
Copy link
Member

There are new test failures on [cfe] Handle bool.hasEnvironment constructor in constant evaluation.

These are due to the breaking change #40678 that changes the default value for int.fromEnvironment and String.fromEnvironment.

The tests

co19_2/LibTest/core/int/int.fromEnvironment_A01_t01 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/01 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/01 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/05 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/05 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/10 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/10 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/15 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/15 RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/none RuntimeError (expected Pass)
corelib/from_environment_const_type_undefined_test/none RuntimeError (expected Pass)
corelib/int_from_environment2_test RuntimeError (expected Pass)
corelib/int_from_environment2_test RuntimeError (expected Pass)
corelib_2/from_environment_const_type_undefined_test/01 RuntimeError (expected Pass)
corelib_2/from_environment_const_type_undefined_test/05 RuntimeError (expected Pass)
corelib_2/from_environment_const_type_undefined_test/10 RuntimeError (expected Pass)
corelib_2/from_environment_const_type_undefined_test/15 RuntimeError (expected Pass)
corelib_2/from_environment_const_type_undefined_test/none RuntimeError (expected Pass)
corelib_2/int_from_environment2_test RuntimeError (expected Pass)
dart2js_extra/new_from_env_test RuntimeError (expected Pass)
language_2/string/const_interpolation2_test RuntimeError (expected Pass)
lib_2/isolate/int_from_environment_default_value_test/0 RuntimeError (expected Pass)
lib_2/isolate/int_from_environment_default_value_test/1 RuntimeError (expected Pass)

are failing on configurations

dart2js-hostasserts-weak-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-d8
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
@johnniwinther johnniwinther added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Mar 17, 2020
@eernstg
Copy link
Member

eernstg commented Mar 17, 2020

Duplication: The required changes to co19_2/LibTest/core/int/int.fromEnvironment_A01_t01 are already requested in dart-lang/co19#540 (comment).

@eernstg eernstg self-assigned this Mar 17, 2020
@eernstg
Copy link
Member

eernstg commented Mar 17, 2020

@eernstg
Copy link
Member

eernstg commented Mar 17, 2020

Done in 568255d.

@eernstg eernstg closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

2 participants