Dart GYP settings for Visual Studio are Incorrect

[DartBot]

This issue was originally filed by [email protected]

---

GYP settings for builds within VS are incorrect.

1. _DEBUG should be defined for Debug builds.
2. The runtime library is not set within the GYP file so it defaults to the MultiThreadedDLL, not MultiThreadedDebugDLL.

Attached patch fixes the two issues.

Some additional issues when building in VS that are not addressed in the patch.

1. Release builds generate debug information (could be intentional so patch does not attempt to fix).
2. Exception handling is disabled but Dart uses STL which will attempt to use exceptions. Warnings are generated because of this.

---

Attachment:
build.patch (953 Bytes)

[DartBot]

This comment was originally written by [email protected]

---

Updated patch file with spaces instead of tabs.

---

Attachment:
build.patch (977 Bytes)

[sethladd]

Thanks for the patch, Don. Is this for VS 2008 or 2010 ?

---

Added Area-Build, Triaged labels.

[sethladd]

Hi Don,

Please fill out http://code.google.com/legal/individual-cla-v1.0.html with your email. Thanks!

[DartBot]

This comment was originally written by [email protected]

---

RuntimeLibrary applies to pre-MSBuild (-2008) and MSBuild(2010+) http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/MSVSSettings.py#­599

So that and the _DEBUG should get all VS versions up and running properly.

Form is filled out with this email address.

[ricowind]

Landed in revision 10366, thank you for the patch, always appreciated.

---

Added Fixed label.

[ricowind]

Reoppening this since I had to revert the change - it causes linking issues on our windows buildbots:
http://chromegw.corp.google.com/i/client.dart/builders/vm-win32-release/builds/5639/steps/build/logs/stdio

---

Added Accepted label.

[DartBot]

This comment was originally written by [email protected]

---

Can the relevant portions be added to the ticket? I can't access that url to see what the linker errors are.

[anders-sandholm]

Removed Area-Build label.
Added Area-Infrastructure label.

[athomas]

Closing. GYP is long gone.