Skip to content

[CP][beta channel] Fix crash when developing with DDC #43453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Sep 16, 2020 · 1 comment
Closed

[CP][beta channel] Fix crash when developing with DDC #43453

sigmundch opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@sigmundch
Copy link
Member

commit(s) to merge: 53895b2

merge instructions: clean merge

What is the issue: DDC had an old undiscovered bug. A certain rare code pattern triggers the issue and in that case the app cannot be loaded for development (the code crashes while loading). The pattern involves an inheritance chain that forms a cycle between classes and type parameters.

Recently a Flutter Web app encountered this pattern and started hitting this issue.

What is the fix: A change in DDC to break the cycle in the generated code.

Why cherrypick: We only know of one affected customer, but the result makes the product unusable in that case.

Risk: low, change is relatively small, we'll get a better signal of risk after the next roll to internal customers tomorrow.

Link to original issue(s): flutter/flutter#64011

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @yjbanov @Markzipan @pcsosinski

@athomas
Copy link
Member

athomas commented Sep 23, 2020

Merged to beta in 4215dca (2.10.0-110.5.beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Development

No branches or pull requests

3 participants