Skip to content

[CP][stable channel] Fix for VM crash with type mis-match https://github.com/dart-lang/sdk/issues/43464 #43685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Oct 5, 2020 · 4 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@a-siva
Copy link
Contributor

a-siva commented Oct 5, 2020

commit(s) to merge: 68fd2a9

merge instructions: clean merge

What is the issue: type assumption could lead to unsound optimizations. This leads to program crashes when flutter users are developing applications.

What is the fix: The code was reworked to make pessimistic type assumptions that will not lead to unsound optimizations.

Why cherrypick: Flutter users can hit this bug which developing applications resulting in crashes that could be hard to diagnose down to this issue, the fix itself is small and safe.

Risk: Low risk, patch is self-contained as validated for some time.

Link to original issue(s): #43464

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-review Issue that need cherry pick triage to approve labels Oct 5, 2020
@vsmenon
Copy link
Member

vsmenon commented Oct 5, 2020

Have we validated that this commit rolled successfully into Flutter master and into g3?

@a-siva
Copy link
Contributor Author

a-siva commented Oct 6, 2020

The change has rolled into flutter and google3 (the last google3 roll done today was with dart version 9560a32779 which includes this change

@vsmenon
Copy link
Member

vsmenon commented Oct 6, 2020

lgtm

@franklinyow
Copy link
Contributor

Approved

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Development

No branches or pull requests

4 participants