Skip to content

[CP][stable channel] Attach unboxing info to unreachable members #44609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Jan 7, 2021 · 4 comments
Closed

[CP][stable channel] Attach unboxing info to unreachable members #44609

a-siva opened this issue Jan 7, 2021 · 4 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta merge-to-stable

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 7, 2021

commit(s) to merge: 3bef6cf

merge instructions: clean merge

What is the issue: #44563

What is the fix: Unreachable members could be used as interface targets of dispatch
table calls, so they should have correct unboxing metadata

Why cherrypick: The bug manifests as a core dump and could potentially happen in the field, the cost of evaluating crashes and root causing it is high, proactively fixing bugs that lead to crashes generally helps.

Risk: Low

Link to original issue(s): #44563
https://github.com/wm17/flutter_switch_segfault

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

@a-siva a-siva added merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jan 7, 2021
@franklinyow franklinyow added merge-to-beta cherry-pick-approved Label for approved cherrypick request labels Jan 7, 2021
@franklinyow
Copy link
Contributor

Approved in SCRUM meeting.

@franklinyow
Copy link
Contributor

For changelog.md:
This is a patch release that fixes a condition that result in a crash in the VM. (#44563 )

@athomas
Copy link
Member

athomas commented Jan 12, 2021

Merged to beta in 2b88e9d (2.12.0-133.7.beta).

Issue will remain open until merged to stable as well.

@athomas
Copy link
Member

athomas commented Jan 21, 2021

Merged to stable in 2ea318b (2.10.5).

@athomas athomas closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta merge-to-stable
Projects
None yet
Development

No branches or pull requests

3 participants