Skip to content

Validate that all tests are passing for non-function type aliases prior to release. #44966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leafpetersen opened this issue Feb 11, 2021 · 5 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). language-nonfunction-type-aliases Issues related to non-function type aliases P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@leafpetersen
Copy link
Member

This issue tracks support of the non-function type alias feature. See the enclosing meta-issue for details.

cc @franklinyow @eernstg @mit-mit

@eernstg
Copy link
Member

eernstg commented Feb 12, 2021

As of Feb 11 2021, https://dart-review.googlesource.com/c/sdk/+/184460 migrates all non-function type alias legacy tests to mixed-version tests where the non-function type aliases are declared in an opted-in library and the remaining code is in an opted-out library.

They are all passing, except language/nonfunction_type_aliases/mixed/aliased_cyclic_superclass_error_test.dart, whose failure occurs because test.py does not recognize the // ^, // [analyzer] .. error expectation syntax when it occurs in a non-entry-point library, cf. #44990.

@eernstg
Copy link
Member

eernstg commented Feb 12, 2021

@leafpetersen, do you expect this check to be repeated up to the release event, or is it a one-shot validation? If it is the latter then I believe that we can close this.

@leafpetersen
Copy link
Member Author

I'd like to leave this open until we're sure that we've landed all of the tests that we're going to land. I'm assuming we will need (at least) tests for the new cyclic typedef resolution rules?

@leafpetersen
Copy link
Member Author

Also, this is intended to cover co19 tests as well, are those all passing?

@franklinyow franklinyow added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Feb 18, 2021
@eernstg eernstg added the language-nonfunction-type-aliases Issues related to non-function type aliases label Feb 23, 2021
@franklinyow franklinyow added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Mar 25, 2021
@leafpetersen
Copy link
Member Author

Looking good here, zero failing tests except the known bad co19 tests waiting a roll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). language-nonfunction-type-aliases Issues related to non-function type aliases P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants