Skip to content

Static error testing doesn't handle error in imported libraries #45333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue Mar 16, 2021 · 2 comments
Closed

Static error testing doesn't handle error in imported libraries #45333

johnniwinther opened this issue Mar 16, 2021 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-duplicate Closed in favor of an existing report

Comments

@johnniwinther
Copy link
Member

The test language/nonfunction_type_aliases/mixed/aliased_cyclic_superclass_error_test assumes errors reported in an imported library. The static error tests framework doesn't seem to handle that.
@johnniwinther johnniwinther added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Mar 16, 2021
@johnniwinther
Copy link
Member Author

cc @eernstg @munificent

@eernstg
Copy link
Member

eernstg commented Mar 16, 2021

True, this has been reported as #44990 (so I think this one is a duplicate). I also changed said test in https://dart-review.googlesource.com/c/sdk/+/191365, such that we can see the actual behavior of tools as intended.

@munificent munificent added the closed-duplicate Closed in favor of an existing report label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@munificent @eernstg @johnniwinther