Skip to content

Provide an icon config when compile exe #45373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liudonghua123 opened this issue Mar 19, 2021 · 1 comment
Closed

Provide an icon config when compile exe #45373

liudonghua123 opened this issue Mar 19, 2021 · 1 comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool.

Comments

@liudonghua123
Copy link

Thank you for taking the time to file an issue!

  • Dart SDK Version (dart --version) Dart SDK version: 2.12.1 (stable) (Wed Mar 10 10:18:47 2021 +0100) on "windows_x64"
  • Whether you are using Windows, MacOSX, or Linux (if applicable) Windows
  • Whether you are using Chrome, Safari, Firefox, Edge (if applicable)

I want to add an icon to a dart console app, but I tried using rcedit, resourcehacker, none of them works, see electron/rcedit#91 (comment) for more details. Maybe the exe compiled from dart is not an ordinary exe like msvc, rust build, I tried to add icon to exe build from rust, it is ok.

I hope the dart compile could support this feature built-in.

@vsmenon vsmenon added the area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. label Mar 19, 2021
@liudonghua123
Copy link
Author

liudonghua123 commented Mar 31, 2022

It seems fixed in 2.17.0-246.0.dev. see related signing issue #39106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool.
Projects
None yet
Development

No branches or pull requests

2 participants