-
Notifications
You must be signed in to change notification settings - Fork 1.7k
breaking change: removing WebSQL APIs #46316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
LGTM. I found no usages within AngularDart or any client code within Google. |
As the original author of the WebSQL proposal I heartily endorse this change. |
Approved! |
lgtm! |
LGTM. I can't find any real usages of it in Google3. |
Approved. Please add the proper Milestone for this. |
@sigmundch - is this going out as part of 2.14 or 2.15? |
2.15 - The deprecation of WebSQL went out in 2.14 (landed in d52475c1663). However the deletion of the APIs hasn't happened yet. |
@sigmundch can you confirm that these are now fully removed? |
Confirmed - the change that fully removed support for it (38b5a84) was released in 2.15.0. The only thing that remains is cleanup on our end, but that's not visible to external developers. |
The WebSQL standard was abandoned more than 10 years ago and is not supported by many browsers.
The
dart:web_sql
library has been documented as unsupported and deprecated for several years as well and but wasn't annotated properly. Since Dart 2.14dart:web_sql
and the relatedwindow.openDatabase
API exposed bydart:html
have been marked deprecated.We plan to completely remove these APIs in a future Dart release, likely in Dart 2.15.
What can break?
Any app that imports
dart:web_sql
or that useswindow.openDatabase
would start seeing compile-time errors.Mitigation
The main mitigation is to remove any imports to
dart:web_sql
and uses ofwindow.openDatabase
.We don't expect uses of these APIs though, given how the underlying functionality is missing in many browsers. If however, such uses exist (say for a chrome-only app), the recommendation is to switch to use either web storage or indexeddb.
We did a study in internal systems and in 15K external packages (using
pub_crawl
) and didn't find any relevant uses of these APIs. We found only two benign matches: one in a discontinued package, and one in a autogenerated library that mocksdart:html
and reachable libraries.@franklinyow @vsmenon @mit-mit @kevmoo
@grouma @Hixie - for approvals
The text was updated successfully, but these errors were encountered: