Skip to content

[CP] Update documentation of SendPort.send to be more precise #47640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkustermann opened this issue Nov 5, 2021 · 2 comments
Closed

[CP] Update documentation of SendPort.send to be more precise #47640

mkustermann opened this issue Nov 5, 2021 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request

Comments

@mkustermann
Copy link
Member

commit(s) to merge: 6225f46

merge instructions: clean (auto)merge (on 2.15.0-268.0.dev which will become the beta branch according to infra)

What is the issue: Clarifies what objects can be sent across SendPorts.

What is the fix: Make the API documentation less ambiguous

Why cherrypick: The next stable release will launch with more performant and more feature-rich concurrency support. We'd like to ensure users do understand what they can send across SendPorts and what they cannot.

Risk: low

Link to original issue(s):
#46623

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @devoncarew
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-review Issue that need cherry pick triage to approve labels Nov 5, 2021
@devoncarew devoncarew added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Nov 9, 2021
@devoncarew
Copy link
Member

approved

@athomas
Copy link
Member

athomas commented Nov 10, 2021

Merged to beta in c8b50bd (2.15.0-268.8.beta).

@athomas athomas closed this as completed Nov 10, 2021
@godofredoc godofredoc mentioned this issue Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devoncarew @mkustermann @athomas