Skip to content

Angular compiler implementation for super-initializer parameters #48073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #48055
devoncarew opened this issue Jan 4, 2022 · 9 comments
Closed
Tracked by #48055

Angular compiler implementation for super-initializer parameters #48073

devoncarew opened this issue Jan 4, 2022 · 9 comments
Assignees
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.

Comments

@devoncarew
Copy link
Member

devoncarew commented Jan 4, 2022

See #48055 for the main tracking issue.

@devoncarew
Copy link
Member Author

cc @leonsenft

@devoncarew devoncarew changed the title Angular compiler implementation for super-initializer parameters (todo:) Angular compiler implementation for super-initializer parameters Jan 4, 2022
@devoncarew devoncarew added the area-google3 Tracking issues for internal work. Note that this area is not triaged. label Jan 4, 2022
@maopanglin
Copy link

There are two ways that AngularDart might need to consider but I am not worried about this change.

  1. The generated code part. The Angular compiler doesn't generate code like this pattern.
  2. Clients' Angular Dart code source. The Angular compiler can rely on Dart analyzer to extract the right nodes.

@leonsenft
Copy link

leonsenft commented Jan 6, 2022

Regarding (2), I think there are some unanswered questions around dependency injection annotations on super-initializer parameters. See my thoughts in http://b/213383778.

@leafpetersen
Copy link
Member

FYI, the flag has been flipped so these can be used without a flag internally now.

@jodinathan
Copy link

this will be so useful for Angular DI...
any public Angular repo that we can try this out?

@leafpetersen
Copy link
Member

This is still in progress.

@leafpetersen leafpetersen reopened this May 6, 2022
@mattrberry
Copy link
Contributor

The internal bug has just been wrapped up. All set to close this issue now.

@leafpetersen
Copy link
Member

Thanks!

@jodinathan
Copy link

we know that if Google was to publish their internal AngularDart it would mean lots of breaking changes, however, we are very ok with that.
Before we dig the compiler and other internal stuff and have many hours of rework, maybe we would come with a plan to start publishing AngularDart again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.
Projects
None yet
Development

No branches or pull requests

8 participants