Skip to content

[Records] Analyzer implementation #49714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
itsjustkevin opened this issue Aug 19, 2022 · 9 comments
Closed
7 tasks done

[Records] Analyzer implementation #49714

itsjustkevin opened this issue Aug 19, 2022 · 9 comments
Assignees
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone

Comments

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Aug 19, 2022

The following is a list of the individual features that need to be considered. The features are listed roughly in dependency order.

@bwilkerson bwilkerson added legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 19, 2022
@itsjustkevin
Copy link
Contributor Author

@srawlins what items are needed to call this feature work done?

@srawlins
Copy link
Member

srawlins commented Sep 8, 2022

@scheglov @bwilkerson would you like to itemize the work? I could also go through the commit history and make a checkbox list.

@srawlins srawlins assigned scheglov and bwilkerson and unassigned srawlins Sep 8, 2022
@bwilkerson
Copy link
Member

I updated it by copying pkg/analyzer/doc/process/new_language_feature.md, which might or might not be complete.

@itsjustkevin
Copy link
Contributor Author

@bwilkerson have you found that these items cover most necessary work? Is there anything in that list I should update?

@bwilkerson
Copy link
Member

@scheglov can confirm, but I believe that the list above is reasonably complete and that the analyzer, aside from a couple of known bugs, is complete.

@scheglov
Copy link
Contributor

Yes, I think the analyzer implementation is probably complete.

However there are still discussions about parsing ambiguous code, and corresponding parser changes, and there is a bucket of co19 tests failing because of the need to disambiguate. So, there might be something new to be uncovered with tests.

@itsjustkevin
Copy link
Contributor Author

@bwilkerson and @scheglov thank you for providing clarity around this issue!

@srawlins srawlins modified the milestones: Dart 3 stable, Dart 3 beta 2 Nov 30, 2022
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Feb 7, 2023
@srawlins
Copy link
Member

srawlins commented Feb 7, 2023

@scheglov how about now? Did the change regarding whitespace in an annotation land? And the change to make the first value in a record, $1, did that land?

@scheglov
Copy link
Contributor

scheglov commented Feb 8, 2023

I believe we can mark "records" done.

@scheglov scheglov closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants