Support "fixing" switches with cascading conditions into switch expressions with ||

[kevmoo]

I think I'm using the terms correctly.

  int get elementSize {
    switch (type) {
      case 'float':
      case 'int':
        return 4;
      case 'short':
        return 2;
      case 'byte':
        return 1;
      default:
        return 0;
    }

should have a suggested fix to

    return switch (type) {
      'float' || 'int' => 4,
      'short' => 2,
      'byte' => 1,
      _ => 0
    };

but it does not!

[pq]

Yeah. We don't currently have the smarts to handle:

case 'float':
case 'int':
  return 4;

(but we should add 'em!)

[parlough]

An interesting workaround here is that you can convert to an if-case statement chain, then back to a switch statement, then finally to a switch expression :P

[FMorschel]

I believe this specific ask was already solved by #54567 (@srawlins to close this). I also created my request to it #55861 missing both.

Current related issues that I know of (1 request to separate the assist to merge the cases and 2 bugs with the current assist respectively):

• Assist for merging single-body swicth cases with a logical-or pattern #56180
• Switch expressions assist conversion with OR removes comments #56597
• Convert to switch expression/statement assists don't trigger formatting #56602

There are also some other issues I created related to the formatter and some suggested lints all linked to the above issues.

[srawlins]

Ah excellent, closing then.