Skip to content

[test_runner] Test runner doesn't support errors in augmentations #55127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgrekhov opened this issue Mar 7, 2024 · 2 comments
Closed

[test_runner] Test runner doesn't support errors in augmentations #55127

sgrekhov opened this issue Mar 7, 2024 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Mar 7, 2024

#44990 was fixed (thanks to @davidmorgan) but now it turned out that the test runner doesn't support expected errors. I'd be very useful to add this support (I'm working on tests for Augmentation libraries now)

cc @davidmorgan @eernstg
@sgrekhov sgrekhov added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Mar 7, 2024
@eernstg
Copy link
Member

eernstg commented Mar 7, 2024

OK, I reopened that issue.

@sgrekhov
Copy link
Contributor Author

Fixed by https://dart-review.googlesource.com/c/sdk/+/356401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg