"Convert 'forEach' to a 'for' loop" should consider prefer_final_in_for_each

[FMorschel]

The fix Convert 'forEach' to a 'for' loop (lint avoid_function_literals_in_foreach_calls) should consider prefer_final_in_for_each.

Today:

var list = [];
list.forEach((v) => print(v));    //   <- assist available

Becomes:

var list = [];
for (var v in list) {        // <- lint `prefer_final_in_for_each` on `v`
  print(v);
}

---

I volunteer to fix this.

[dart-github-bot]

Summary: The "Convert 'forEach' to a 'for' loop" quick fix should consider the prefer_final_in_for_each lint when converting a forEach loop to a for loop. Currently, the fix creates a var variable in the for loop, which triggers the lint.

[FMorschel]

https://dart-review.googlesource.com/c/sdk/+/389380