Skip to content

False positive in invariant_booleans. #57684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zoechi opened this issue Mar 9, 2018 · 2 comments
Closed

False positive in invariant_booleans. #57684

zoechi opened this issue Mar 9, 2018 · 2 comments
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive P4 type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@zoechi
Copy link
Contributor

zoechi commented Mar 9, 2018

image

It doesn't seem to recognize that there is still the uncovered case where both are equal
@bwilkerson
Copy link
Member

@alexeieleusis

@pq pq added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Mar 10, 2018
@pq pq changed the title Should not unconditionally evaluate to true False positive in invariant_booleans. Jun 27, 2018
@pq pq added linter-false-positive type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jun 27, 2018
This was referenced Jan 4, 2019
Merged
Merged
Merged
@pq pq mentioned this issue Nov 18, 2024
Closed
@pq pq mentioned this issue Feb 5, 2019
Merged
@pq pq mentioned this issue Nov 18, 2024
Closed
@srawlins srawlins added the P4 label Sep 22, 2022
@srawlins
Copy link
Member

We've deprecated invariant_booleans and will not be fixing correctness bugs going forward.

@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
@srawlins srawlins mentioned this issue Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive P4 type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pq @srawlins @zoechi @devoncarew @bwilkerson