Skip to content

lints to promote spread collections #57895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pq opened this issue Jan 31, 2019 · 5 comments
Closed

lints to promote spread collections #57895

pq opened this issue Jan 31, 2019 · 5 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature type-question A question about expected behavior or functionality

Comments

@pq
Copy link
Member

pq commented Jan 31, 2019

Placeholder for conversations around lints to promote the use of spread-collections (feature spec, implementation plan).

@munificent: ideally I'd like to see lints discussed/tracked in the implementation plan. Does that sound reasonable? What's the process for updating it? Should I add a discussion to the tracking bug?

/cc @stereotype441 @bwilkerson

@pq pq added contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-question A question about expected behavior or functionality area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). linter-new-language-feature labels Jan 31, 2019
@munificent
Copy link
Member

Feel free to just send a pull request with the changes to the implementation plan. I'd love to see the linter on there.

@bwilkerson
Copy link
Member

FWIW, I have a couple of quick assists nearly ready. We should coordinate so that the lints flag the cases the assists can handle.

@pq
Copy link
Member Author

pq commented Feb 1, 2019

Thanks @munificent. dart-lang/language#201 opened.

FWIW, I have a couple of quick assists nearly ready. We should coordinate so that the lints flag the cases the assists can handle.

Fantastic! Does analyzer 0.35.0 have enough support that we can start implementing or do we need to wait for another push?

@bwilkerson
Copy link
Member

I'm not entirely certain. I know that it contains the AST changes to represent the new constructs (that's why it was a breaking change), but I think the parser was incomplete at that point. Resolution was, and still is, incomplete, but the assist is primarily syntactic in nature, and I'd guess that the lint would be too.

@pq
Copy link
Member Author

pq commented Feb 1, 2019

After some conversations w/ @bwilkerson and @stereotype441, I'm leaning towards a process that mirrors how analyzer and other tools phase their implementations. As a result, closing this in favor of: #57897 and #57898.

@pq pq closed this as completed Feb 1, 2019
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature type-question A question about expected behavior or functionality
Projects
None yet
Development

No branches or pull requests

4 participants