Skip to content

avoid_implementing_value_types false positives #58042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmorgan opened this issue Oct 28, 2019 · 0 comments
Open

avoid_implementing_value_types false positives #58042

davidmorgan opened this issue Oct 28, 2019 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. customer-google3 devexp-linter Issues with the analyzer's support for the linter package linter-false-positive P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@davidmorgan
Copy link
Contributor

Types that implement something in the dart:html package that descend from Interceptor cause false positives in this lint, because Interceptor has Object-like implementations of operator== and hashCode, making all these classes look like value types to the lint.

e.g. class MockHttpRequest extends Mock implements HttpRequest {} should not violate this lint.

Likely the lint needs to special case Interceptor.

@pq pq added customer-google3 type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) linter-false-positive labels Oct 28, 2019
@srawlins srawlins added the P3 A lower priority bug or feature request label Sep 23, 2022
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. customer-google3 devexp-linter Issues with the analyzer's support for the linter package linter-false-positive P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants