cascade_invocations false positives

[davidmorgan]

cascade_invocations currently fires for:

import 'dart:async';

void main() {
  var stream = StreamController().stream;
  var subscription = stream.listen(null);
  subscription.onData((value) { print(subscription); });
}

But it's impossible to use the cascade operator here because of the reference to subscriptions inside the lambda.

I see two paths forward:

#57147 don't fire when there is a reference like this
#57148 simpler: never fire when the first line is a variable declaration

My personal preference is for #57148; I think splitting the declaration from operations on the variable is often beneficial to readability, and should be treated as a special case.

WDYT, please?

Thanks!

[jamesderlin]

This looks like the same thing I complained about in #57944.

Edit:
Looking again, similar, but not quite the same. There's a more general potential problem with mixing the cascade operator with assignments, but declarations are a more specialized (and probably more easily identifiable) situation.

[asashour]

Is this still valid, I am unable to reproduce.