Skip to content

prefer_asserts_in_initializer_lists support for extension types #59324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #58838
pq opened this issue Oct 11, 2023 · 1 comment
Closed
Tracked by #58838

prefer_asserts_in_initializer_lists support for extension types #59324

pq opened this issue Oct 11, 2023 · 1 comment
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.

Comments

@pq
Copy link
Member

pq commented Oct 11, 2023

No description provided.

@pq pq self-assigned this Oct 11, 2023
@pq pq mentioned this issue Nov 19, 2024
Open
44 tasks
copybara-service bot referenced this issue Oct 12, 2023
@pq
verify prefer_asserts_in_initializer_lists for extension types
3f3def4 
As it happens, `prefer_asserts_in_initializer_lists` works out of the box for constructors in extension types. (Yay!) This just adds a few tests for coverage.

Fixes: https://github.com/dart-lang/linter/issues/4779

Change-Id: I1f5ffbbc968b37723b5e6894227c154563b2803c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330031
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Kallen Tu <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq
Copy link
Member Author

pq commented Oct 12, 2023

Addressed w/ 3f3def4.

@pq pq closed this as completed Oct 12, 2023
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew