-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Dot Shorthands] Core library updates #59876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is no urgency. We can choose to use it everywhere it applies, as a style statement, or we can update code when we touch it anyway. |
Sounds good to me. |
We should probably also consider whether there are any constants that should now be declared inside another class, because you'd want to use shorthands for them. I quick search of the core platform libraries ( The extension type XYZW(int _) implements int {
static const XYZW xxxx = 0x00;
// ...
static const XYZW www = 0xFF;
} and made the argument to So probably nothing further to do, but platform specific libraries might want to check. |
Same suggestion has been made for Solutions, long-term, would be to have "extension type aliases" which are both subtypes and supertypes of the representation type, so Nothing to do right now. |
@lrhn Another potential use case would be the constants in Lines 337 to 409 in 8516bc1
|
This issue tracks the changes we want to make to the core libraries with the dot shorthands feature.
I believe we'll have a lint that converts typed static accesses to dot shorthand form (
Color.blue
->.blue
). Do we want to change any part of the core libraries to use dot shorthands?And any other changes we need to make?
cc. @lrhn
The text was updated successfully, but these errors were encountered: