Skip to content

Import library combinator fixes should consider lint and multiple combinators #60131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FMorschel opened this issue Feb 14, 2025 · 2 comments
Closed

Import library combinator fixes should consider lint and multiple combinators #60131

FMorschel opened this issue Feb 14, 2025 · 2 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-quick-fix Issues with analysis server (quick) fixes P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@FMorschel
Copy link
Contributor

This is basically a revisiting of IMPORT_LIBRARY_COMBINATOR and IMPORT_LIBRARY_COMBINATOR_MULTIPLE. I've made them work with both hide and show previously. Now after completing #56830 I was reminded by @bwilkerson that we should update more than one combinator (if the user has it) so the code actually works.

Today both fixes are hard-coded to a single combinator so the idea is to make them work if you have multiple.

I also added support in the same commit for the combinators_ordering lint so I'd like to be coherent here too and follow its ruling for sorting the combinators.
@FMorschel FMorschel added the legacy-area-analyzer Use area-devexp instead. label Feb 14, 2025
@FMorschel
Copy link
Contributor Author

Here is the CL https://dart-review.googlesource.com/c/sdk/+/409765

@srawlins srawlins added P3 A lower priority bug or feature request devexp-quick-fix Issues with analysis server (quick) fixes type-enhancement A request for a change that isn't a bug labels Feb 18, 2025
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
@FMorschel
Copy link
Contributor Author

FMorschel commented Mar 12, 2025 •
edited
Loading

Can I get some reviews here please @srawlins / @pq and @scheglov? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-quick-fix Issues with analysis server (quick) fixes P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @bwilkerson @FMorschel