Dart2JS's unwrapException appears to be fragile

[blois]

unwrapException relies on the message of the exception to determine what type of Dart exception object it should be, but this appears to be fragile and prone to changes in browsers.

For example, Chrome appears to have recently changed the message when functions cannot be found.

[peter-ahe-google]

Added Duplicate label.
Marked as being merged into #3313.

[peter-ahe-google]

Upon further consideration, I think the problem is our interceptor implementation. Pete: could you provide an example or a bad stack trace?

---

Set owner to @peter-ahe-google.
Added this to the M3 milestone.
Added NeedsInfo label.
Marked as being merged into #.

[ErikCorryGoogle]

Possible fix was committed here:
https://codereview.chromium.org/11645050/

[blois]

Correct, also see:
https://codereview.chromium.org/11644053/

Latest Chrome developer builds changed the error's message and also removed some of the properties so it now looks much more like FireFox.

This was the source of the failures in build:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-chrome-linux/builds/1971

Note that we only saw these errors yesterday on the Linux Chrome dev builds, but I assume it will be rolling out more widely.

[peter-ahe-google]

Do we know why Chrome removed these properties? Aligning with Firefox is suboptimal for compiling other languages to JavaScript. We need to get some kind of error code, precisely like Internet Explorer provides or Chrome used to provide. Relying on localized strings is dreadful :-(

[blois]

I don't have any background on Chrome's change though the new behavior appears to be a closer implementation of the js language spec.

[peter-ahe-google]

Removed this from the M3 milestone.
Added this to the M4 milestone.

[kasperl]

Removed this from the M4 milestone.
Added this to the M5 milestone.

[kasperl]

Added TriageForM5 label.

[kasperl]

Removed this from the M5 milestone.
Added this to the Later milestone.
Removed TriageForM5 label.

[peter-ahe-google]

Fixed in r25262.

---

Added Fixed label.