Skip to content

Move Point and Rect to dart:math #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Mar 17, 2013 · 14 comments
Closed

Move Point and Rect to dart:math #9213

kevmoo opened this issue Mar 17, 2013 · 14 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html library-math type-enhancement A request for a change that isn't a bug
Milestone

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 17, 2013

These are too general to be limited to browser-only apps.

I have a number of geometry types in a non-browser lib. Being able to leverage the same Rect and Point everywhere is ideal.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 17, 2013

Removed Type-Defect label.
Added Type-Enhancement, Library-Math, Library-Html labels.

@DartBot
Copy link

DartBot commented Mar 17, 2013

This comment was originally written by @seaneagan


or create a new dart:geometry library, see issue #3107.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 17, 2013

Hmm. Not sure I'd go that far. I think everything used by dart:html should be shareable. To keep v1 simple and to encourage creativity and flexibility in other libraries, I'd keep the set of types very small.

@DartBot
Copy link

DartBot commented Mar 17, 2013

This comment was originally written by @seaneagan


agree with keeping the set of types small for v1. but having them in their own library will make it easier to extend post-v1, such as the types mentioned in issue #9212.

@kasperl
Copy link

kasperl commented Mar 18, 2013

Added Triaged label.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 26, 2013

cc @jmesserly.

@DartBot
Copy link

DartBot commented Apr 8, 2013

This comment was originally written by [email protected]


Added Area-Library label.

@kevmoo
Copy link
Member Author

kevmoo commented Sep 30, 2013

https://codereview.chromium.org/25113002/


Set owner to @efortuna.
Added Started label.

@kevmoo
Copy link
Member Author

kevmoo commented Oct 2, 2013

Fixed r28184


Added Fixed label.

@efortuna
Copy link
Contributor

efortuna commented Oct 2, 2013

you robbed me of my satisfaction of marking it as fixed! ;-)

@kevmoo
Copy link
Member Author

kevmoo commented Oct 2, 2013

Nevermind...


Added Started label.

@efortuna
Copy link
Contributor

efortuna commented Oct 2, 2013

Added this to the M8 milestone.

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2013

Waiting on https://codereview.chromium.org/25698003/
Then it can be committed!!

@efortuna
Copy link
Contributor

efortuna commented Oct 4, 2013

https://codereview.chromium.org//25808002

Fixed!


Added Fixed label.

@kevmoo kevmoo added Type-Enhancement library-math library-html area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Oct 4, 2013
@kevmoo kevmoo added this to the M8 milestone Oct 4, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html library-math type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants