Skip to content

Platform selectors for dart2js/dartdevc #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
greglittlefield-wf opened this issue Jun 20, 2017 · 2 comments
Closed

Platform selectors for dart2js/dartdevc #652

greglittlefield-wf opened this issue Jun 20, 2017 · 2 comments
Labels
status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug

Comments

@greglittlefield-wf
Copy link
Contributor

There is the potential for behavioral differences between dart2js and the dev compiler, and it would be nice to be able to be able to use platform selectors to run tests on one and not the other. (Is this even possible, since running tests in the DDC relies on a separate Pub server that the test package has no knowledge of?)

For instance, there are some known bugs in the dev compiler output that break certain tests, and we'd like to avoid running those tests until the bugs are fixed in the SDK.

For now, we're using tags, but it'd be nice to not have to pass those in when running the tests.

@grouma
Copy link
Member

grouma commented Jun 20, 2017

One possible solution is to use the 'tag' feature and 'tag' tests accordingly.

@nex3
Copy link
Member

nex3 commented Jun 20, 2017

Currently test doesn't have any built-in support for DDC. We can access it through pub serve, but in that case we don't know which compiler produced the JS we're receiving, so we can't propagate that information down into the platform selectors.

At some point I want to make it possible to use preset names in platform selectors, which will allow you to pass -P dartdevc and use that in platform selectors, but unfortunately that's not currently possible.

I'm marking this as blocked on #414.

@nex3 nex3 added status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug labels Jun 20, 2017
@grouma grouma closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants