Skip to content

Commit dfb41c2

Browse files
committed
run CI on all PR branches (#282)
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should. This updates our GitHub CI configs to run checks against PRs against any branch. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
1 parent cc2bec1 commit dfb41c2

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

.github/workflows/cli_config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ permissions: read-all
33

44
on:
55
pull_request:
6-
branches: [main]
76
paths:
87
- ".github/workflows/cli_config.yml"
98
- "pkgs/cli_config/**"

.github/workflows/extension_discovery.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ permissions: read-all
33

44
on:
55
pull_request:
6-
branches: [ main ]
76
paths:
87
- '.github/workflows/unified_analytics.yml'
98
- 'pkgs/extension_discovery/**'

.github/workflows/graphs.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@ name: package:graphs
22
permissions: read-all
33

44
on:
5-
# Run on PRs and pushes to the default branch.
6-
push:
7-
branches: [ main ]
5+
# Run CI on all PRs (against any branch) and on pushes to the main branch.
6+
pull_request:
87
paths:
98
- '.github/workflows/graphs.yml'
109
- 'pkgs/graphs/**'
11-
pull_request:
10+
push:
1211
branches: [ main ]
1312
paths:
1413
- '.github/workflows/graphs.yml'

.github/workflows/unified_analytics.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ permissions: read-all
33

44
on:
55
pull_request:
6-
branches: [ main ]
76
paths:
87
- '.github/workflows/unified_analytics.yml'
98
- 'pkgs/unified_analytics/**'

0 commit comments

Comments
 (0)