Skip to content

The File interface should explicitly declare that it returns Uint8List #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thosakwe opened this issue Jun 6, 2019 · 1 comment
Open

The File interface should explicitly declare that it returns Uint8List #636

thosakwe opened this issue Jun 6, 2019 · 1 comment
Labels
package:file

Comments

@thosakwe
Copy link
Contributor

thosakwe commented Jun 6, 2019

After version 5.0.8, packages using package:file in conjunction with a StreamConsumer<List<int>> will break in recent versions, because you can no longer pipe Stream<Uint8List> to a StreamConsumer<List<int>>. (dart-lang/sdk#37179)

I'm more than willing to send a PR for this, but I think the File interface should include overrides that indicate that calls to openRead, etc. return Uint8List.

It was pretty hard to track this down, but it turned out to be a pretty breaking change in my experience.

Again, willing to send in a PR.
@thosakwe thosakwe mentioned this issue Jun 6, 2019
Closed
@renatoathaydes
Copy link

Related: dart-lang/sdk#39947

@devoncarew devoncarew transferred this issue from dart-archive/file.dart Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devoncarew @renatoathaydes @thosakwe