DOC: Removing spellcheck, failing doc script if sphinx fail, and moving the doc job out of allowed failure jobs

Author: datapythonista

.travis.yml

@@ -60,23 +60,19 @@ matrix:
         apt:
           packages:
           - xsel
-
-    # In allow_failures
     - dist: trusty
       env:
-        - JOB="3.6, slow" ENV_FILE="ci/deps/travis-36-slow.yaml" PATTERN="slow"
+        - JOB="3.6, doc" ENV_FILE="ci/deps/travis-36-doc.yaml" DOC=true
 
     # In allow_failures
     - dist: trusty
       env:
-        - JOB="3.6, doc" ENV_FILE="ci/deps/travis-36-doc.yaml" DOC=true
+        - JOB="3.6, slow" ENV_FILE="ci/deps/travis-36-slow.yaml" PATTERN="slow"
+
     allow_failures:
       - dist: trusty
         env:
           - JOB="3.6, slow" ENV_FILE="ci/deps/travis-36-slow.yaml" PATTERN="slow"
-      - dist: trusty
-        env:
-          - JOB="3.6, doc" ENV_FILE="ci/deps/travis-36-doc.yaml" DOC=true
 
 before_install:
   - echo "before_install"

doc/make.py

@@ -214,7 +214,10 @@ def _run_os(*args):
         # TODO check_call should be more safe, but it fails with
         # exclude patterns, needs investigation
         # subprocess.check_call(args, stderr=subprocess.STDOUT)
-        os.system(' '.join(args))
+        exit_status = os.system(' '.join(args))
+        if exit_status:
+            msg = 'Command "{}" finished with exit code {}'
+            raise RuntimeError(msg.format(' '.join(args), exit_status))
 
     def _sphinx_build(self, kind):
         """Call sphinx to build documentation.

doc/source/conf.py

@@ -77,19 +77,8 @@
               'contributors',  # custom pandas extension
               ]
 
-try:
-    import sphinxcontrib.spelling  # noqa
-except ImportError as err:
-    logger.warn(('sphinxcontrib.spelling failed to import with error "{}". '
-                '`spellcheck` command is not available.'.format(err)))
-else:
-    extensions.append('sphinxcontrib.spelling')
-
 exclude_patterns = ['**.ipynb_checkpoints']
 
-spelling_word_list_filename = ['spelling_wordlist.txt', 'names_wordlist.txt']
-spelling_ignore_pypi_package_names = True
-
 with open("index.rst") as f:
     index_rst_lines = f.readlines()