test: CPP-253 Ensure entire pool is not removed with partial connections

Removed old code and comment from outage test (fixed in CPP-140)

Author: mikefero

test/integration_tests/src/test_outage.cpp

@@ -62,10 +62,6 @@ struct OutageTests : public test_utils::MultipleNodesTest {
     test_utils::CassLog::set_output_log_level(CASS_LOG_DISABLED);
     printf("Warning! This test is going to take %d minutes\n", TEST_DURATION_SECS / 60);
     std::fill(nodes_states, nodes_states + NUM_NODES, UP);
-    // TODO(mpenick): This is a stopgap. To be fixed in CPP-140
-#if !defined(WIN32) && !defined(_WIN32)
-    signal(SIGPIPE, SIG_IGN);
-#endif
   }
 
   int random_int(int s, int e) {

test/integration_tests/src/test_pool.cpp

@@ -22,6 +22,8 @@
 #include "test_utils.hpp"
 #include "cluster.hpp"
 
+#include <uv.h>
+
 #include <boost/scoped_ptr.hpp>
 #include <boost/test/unit_test.hpp>
 
@@ -125,4 +127,53 @@ BOOST_AUTO_TEST_CASE(connection_spawn)
   }
   BOOST_CHECK_EQUAL(test_utils::CassLog::message_count(), 2u);
 }
+
+/**
+ * Create connection interruptions using CCM for four seconds on node 2
+ *
+ * @param ccm CCM bridge pointer
+ */
+static void connection_interruptions(void *ccm) {
+  boost::posix_time::ptime start = boost::posix_time::second_clock::universal_time();
+  while ((boost::posix_time::second_clock::universal_time() - start).total_seconds() < 4) {
+    cql::cql_ccm_bridge_t* ccm_ptr = static_cast<cql::cql_ccm_bridge_t*>(ccm);
+    ccm_ptr->pause(2);
+    ccm_ptr->resume(2);
+  }
+}
+
+/**
+ * Don't Recycle Pool On Connection Timeout
+ *
+ * This test ensures that a pool does not completely remove itself while
+ * allowing partial connections to remain and reconnection attempts to use the
+ * existing pool.
+ *
+ * @since 2.1.0
+ * @test_category connection:connection_pool
+ * @jira_ticket CPP-253 [https://datastax-oss.atlassian.net/browse/CPP-253]
+ */
+BOOST_AUTO_TEST_CASE(dont_recycle_pool_on_timeout) {
+  ccm->bootstrap(2);
+  test_utils::CassLog::reset("Host " + conf.ip_prefix() + "2 already present attempting to initiate immediate connection");
+
+  // Create session during "connection interruptions"
+  cass_cluster_set_connect_timeout(cluster, 1000);
+  cass_cluster_set_num_threads_io(cluster, 16);
+  cass_cluster_set_core_connections_per_host(cluster, 2);
+  cass_cluster_set_load_balance_round_robin(cluster);
+  uv_thread_t connection_interruptions_thread;
+  uv_thread_create(&connection_interruptions_thread, connection_interruptions, ccm.get());
+  test_utils::CassSessionPtr session(test_utils::create_session(cluster));
+  uv_thread_join(&connection_interruptions_thread);
+
+  boost::posix_time::ptime start = boost::posix_time::second_clock::universal_time();
+  while ((boost::posix_time::second_clock::universal_time() - start).total_seconds() < 60) {
+    test_utils::CassStatementPtr statement(cass_statement_new("SELECT * FROM system.local", 0));
+    test_utils::CassFuturePtr(cass_session_execute(session.get(), statement.get()));
+  }
+
+  BOOST_CHECK_GE(test_utils::CassLog::message_count(), 1);
+}
+
 BOOST_AUTO_TEST_SUITE_END()