Skip to content

Commit 18de3d7

Browse files
committed
Make changes suggested by Mark, make this pass sanity
1 parent 14ea772 commit 18de3d7

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

doc/combiner-explainer.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class combiner {
9292

9393
So that explains how combiners work in general. In gRPC, there is
9494
`start_batch(..., tag)` and then work only gets activated by somebody
95-
calling `cq::next` which returns a tag. This gives and API-level
95+
calling `cq::next` which returns a tag. This gives an API-level
9696
guarantee that there will be a thread doing polling to actually make
9797
work happen. However, some operations are not covered by a poller
9898
thread, such as cancellation that doesn't have a completion. Other
@@ -128,12 +128,12 @@ tries to spray events onto as many threads as possible to get as much concurrenc
128128
So `offload` really does:
129129

130130
```
131-
distributor.run(continue_from_while_loop);
131+
workqueue.run(continue_from_while_loop);
132132
break;
133133
```
134134

135-
This needs us to add another class variable for a `distributor`
136-
(called a `workqueue` in the code).
135+
This needs us to add another class variable for a `workqueue`
136+
(which is really conceptually a distributor).
137137

138138
```
139139
workqueue::run(f) {

tools/doxygen/Doxyfile.c++

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
764764
doc/PROTOCOL-WEB.md \
765765
doc/binary-logging.md \
766766
doc/c-style-guide.md \
767+
doc/combiner-explainer.md \
767768
doc/command_line_tool.md \
768769
doc/compression.md \
769770
doc/compression_cookbook.md \

tools/doxygen/Doxyfile.c++.internal

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
764764
doc/PROTOCOL-WEB.md \
765765
doc/binary-logging.md \
766766
doc/c-style-guide.md \
767+
doc/combiner-explainer.md \
767768
doc/command_line_tool.md \
768769
doc/compression.md \
769770
doc/compression_cookbook.md \

tools/doxygen/Doxyfile.core

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
764764
doc/PROTOCOL-WEB.md \
765765
doc/binary-logging.md \
766766
doc/c-style-guide.md \
767+
doc/combiner-explainer.md \
767768
doc/command_line_tool.md \
768769
doc/compression.md \
769770
doc/compression_cookbook.md \

tools/doxygen/Doxyfile.core.internal

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
764764
doc/PROTOCOL-WEB.md \
765765
doc/binary-logging.md \
766766
doc/c-style-guide.md \
767+
doc/combiner-explainer.md \
767768
doc/command_line_tool.md \
768769
doc/compression.md \
769770
doc/compression_cookbook.md \

0 commit comments

Comments
 (0)