Skip to content

Commit e519a03

Browse files
committed
Small improvements to generated documentation
1 parent 4ce5bd1 commit e519a03

File tree

8 files changed

+139
-15
lines changed

8 files changed

+139
-15
lines changed

doc/cpp/perf_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ If message k+1 in a stream does not rely on responses from message k, it's
1010
possible to enable write batching by passing a WriteOptions argument to Write
1111
with the buffer_hint set:
1212

13-
```c++
13+
~~~{.cpp}
1414
stream_writer->Write(message, WriteOptions().set_buffer_hint());
15-
```
15+
~~~
1616

1717
The write will be buffered until one of the following is true:
1818
- the per-stream buffer is filled (controllable with the channel argument

include/grpc++/grpc++.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@
4444
/// peer, compression settings, authentication, etc.
4545
/// - grpc::Server, representing a gRPC server, created by grpc::ServerBuilder.
4646
///
47+
/// Streaming calls are handled with the streaming classes in
48+
/// \ref sync_stream.h and
49+
/// \ref async_stream.h.
50+
///
4751
/// Refer to the
4852
/// [examples](https://github.com/grpc/grpc/blob/master/examples/cpp)
4953
/// for code putting these pieces into play.

include/grpc++/impl/codegen/completion_queue.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,10 @@ class ServerContext;
9494

9595
extern CoreCodegenInterface* g_core_codegen_interface;
9696

97-
/// A thin wrapper around \a grpc_completion_queue (see / \a
98-
/// src/core/surface/completion_queue.h).
97+
/// A thin wrapper around \ref grpc_completion_queue (see \ref
98+
/// src/core/lib/surface/completion_queue.h).
99+
/// See \ref doc/cpp/perf_notes.md for notes on best practices for high
100+
/// performance servers.
99101
class CompletionQueue : private GrpcLibraryCodegen {
100102
public:
101103
/// Default constructor. Implicitly creates a \a grpc_completion_queue

templates/tools/doxygen/Doxyfile.include

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
<%def name="gen_doxyfile(libnames, packagename, collection, internal)">
99
<%
1010
import itertools
11+
import glob
1112
targets = []
13+
docpackage = packagename.replace('+', 'p').lower()
1214
for libname in libnames:
1315
target = None
1416
for p in collection:
@@ -778,13 +780,19 @@ WARN_LOGFILE =
778780
# spaces.
779781
# Note: If this tag is empty the current directory is searched.
780782

781-
INPUT = ${' \\\n'.join(
782-
itertools.chain.from_iterable(
783-
target.public_headers +
784-
([]
785-
if not internal
786-
else target.headers + target.src)
787-
for target in targets))}
783+
INPUT = ${
784+
' \\\n'.join(
785+
itertools.chain(
786+
itertools.chain.from_iterable(
787+
target.public_headers +
788+
([]
789+
if not internal
790+
else target.headers + target.src)
791+
for target in targets),
792+
glob.glob('doc/*.md'),
793+
glob.glob('doc/%s/*.md' % docpackage))
794+
)
795+
}
788796

789797
# This tag can be used to specify the character encoding of the source files
790798
# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses

tools/doxygen/Doxyfile.c++

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,35 @@ include/grpc/impl/codegen/slice.h \
847847
include/grpc/impl/codegen/sync.h \
848848
include/grpc/impl/codegen/sync_generic.h \
849849
include/grpc/impl/codegen/sync_posix.h \
850-
include/grpc/impl/codegen/sync_windows.h
850+
include/grpc/impl/codegen/sync_windows.h \
851+
doc/fail_fast.md \
852+
doc/compression.md \
853+
doc/environment_variables.md \
854+
doc/stress_test_framework.md \
855+
doc/PROTOCOL-WEB.md \
856+
doc/cpp-style-guide.md \
857+
doc/http-grpc-status-mapping.md \
858+
doc/wait-for-ready.md \
859+
doc/command_line_tool.md \
860+
doc/c-style-guide.md \
861+
doc/server_reflection_tutorial.md \
862+
doc/health-checking.md \
863+
doc/connection-backoff-interop-test-description.md \
864+
doc/epoll-polling-engine.md \
865+
doc/naming.md \
866+
doc/binary-logging.md \
867+
doc/connectivity-semantics-and-api.md \
868+
doc/connection-backoff.md \
869+
doc/compression_cookbook.md \
870+
doc/PROTOCOL-HTTP2.md \
871+
doc/load-balancing.md \
872+
doc/negative-http2-interop-test-descriptions.md \
873+
doc/server-reflection.md \
874+
doc/interop-test-descriptions.md \
875+
doc/statuscodes.md \
876+
doc/g_stands_for.md \
877+
doc/cpp/perf_notes.md \
878+
doc/cpp/pending_api_cleanups.md
851879
852880
# This tag can be used to specify the character encoding of the source files
853881
# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses

tools/doxygen/Doxyfile.c++.internal

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,35 @@ src/cpp/util/slice_cc.cc \
893893
src/cpp/util/status.cc \
894894
src/cpp/util/string_ref.cc \
895895
src/cpp/util/time_cc.cc \
896-
src/cpp/codegen/codegen_init.cc
896+
src/cpp/codegen/codegen_init.cc \
897+
doc/fail_fast.md \
898+
doc/compression.md \
899+
doc/environment_variables.md \
900+
doc/stress_test_framework.md \
901+
doc/PROTOCOL-WEB.md \
902+
doc/cpp-style-guide.md \
903+
doc/http-grpc-status-mapping.md \
904+
doc/wait-for-ready.md \
905+
doc/command_line_tool.md \
906+
doc/c-style-guide.md \
907+
doc/server_reflection_tutorial.md \
908+
doc/health-checking.md \
909+
doc/connection-backoff-interop-test-description.md \
910+
doc/epoll-polling-engine.md \
911+
doc/naming.md \
912+
doc/binary-logging.md \
913+
doc/connectivity-semantics-and-api.md \
914+
doc/connection-backoff.md \
915+
doc/compression_cookbook.md \
916+
doc/PROTOCOL-HTTP2.md \
917+
doc/load-balancing.md \
918+
doc/negative-http2-interop-test-descriptions.md \
919+
doc/server-reflection.md \
920+
doc/interop-test-descriptions.md \
921+
doc/statuscodes.md \
922+
doc/g_stands_for.md \
923+
doc/cpp/perf_notes.md \
924+
doc/cpp/pending_api_cleanups.md
897925

898926
# This tag can be used to specify the character encoding of the source files
899927
# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses

tools/doxygen/Doxyfile.core

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,34 @@ include/grpc/impl/codegen/slice.h \
825825
include/grpc/impl/codegen/sync.h \
826826
include/grpc/impl/codegen/sync_generic.h \
827827
include/grpc/impl/codegen/sync_posix.h \
828-
include/grpc/impl/codegen/sync_windows.h
828+
include/grpc/impl/codegen/sync_windows.h \
829+
doc/fail_fast.md \
830+
doc/compression.md \
831+
doc/environment_variables.md \
832+
doc/stress_test_framework.md \
833+
doc/PROTOCOL-WEB.md \
834+
doc/cpp-style-guide.md \
835+
doc/http-grpc-status-mapping.md \
836+
doc/wait-for-ready.md \
837+
doc/command_line_tool.md \
838+
doc/c-style-guide.md \
839+
doc/server_reflection_tutorial.md \
840+
doc/health-checking.md \
841+
doc/connection-backoff-interop-test-description.md \
842+
doc/epoll-polling-engine.md \
843+
doc/naming.md \
844+
doc/binary-logging.md \
845+
doc/connectivity-semantics-and-api.md \
846+
doc/connection-backoff.md \
847+
doc/compression_cookbook.md \
848+
doc/PROTOCOL-HTTP2.md \
849+
doc/load-balancing.md \
850+
doc/negative-http2-interop-test-descriptions.md \
851+
doc/server-reflection.md \
852+
doc/interop-test-descriptions.md \
853+
doc/statuscodes.md \
854+
doc/g_stands_for.md \
855+
doc/core/pending_api_cleanups.md
829856

830857
# This tag can be used to specify the character encoding of the source files
831858
# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses

tools/doxygen/Doxyfile.core.internal

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1276,7 +1276,34 @@ src/core/lib/support/tls_pthread.c \
12761276
src/core/lib/support/tmpfile_msys.c \
12771277
src/core/lib/support/tmpfile_posix.c \
12781278
src/core/lib/support/tmpfile_windows.c \
1279-
src/core/lib/support/wrap_memcpy.c
1279+
src/core/lib/support/wrap_memcpy.c \
1280+
doc/fail_fast.md \
1281+
doc/compression.md \
1282+
doc/environment_variables.md \
1283+
doc/stress_test_framework.md \
1284+
doc/PROTOCOL-WEB.md \
1285+
doc/cpp-style-guide.md \
1286+
doc/http-grpc-status-mapping.md \
1287+
doc/wait-for-ready.md \
1288+
doc/command_line_tool.md \
1289+
doc/c-style-guide.md \
1290+
doc/server_reflection_tutorial.md \
1291+
doc/health-checking.md \
1292+
doc/connection-backoff-interop-test-description.md \
1293+
doc/epoll-polling-engine.md \
1294+
doc/naming.md \
1295+
doc/binary-logging.md \
1296+
doc/connectivity-semantics-and-api.md \
1297+
doc/connection-backoff.md \
1298+
doc/compression_cookbook.md \
1299+
doc/PROTOCOL-HTTP2.md \
1300+
doc/load-balancing.md \
1301+
doc/negative-http2-interop-test-descriptions.md \
1302+
doc/server-reflection.md \
1303+
doc/interop-test-descriptions.md \
1304+
doc/statuscodes.md \
1305+
doc/g_stands_for.md \
1306+
doc/core/pending_api_cleanups.md
12801307

12811308
# This tag can be used to specify the character encoding of the source files
12821309
# that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses

0 commit comments

Comments
 (0)