Skip to content

Commit 8b06260

Browse files
jluebbeWolfram Sang
authored and
Wolfram Sang
committed
i2c: core: only use set_scl for bus recovery after calling prepare_recovery
Using set_scl may be ineffective before calling the driver specific prepare_recovery callback, which might change into a test mode. So instead of setting SCL in i2c_generic_scl_recovery, move it to i2c_generic_recovery (after the optional prepare_recovery). Signed-off-by: Jan Luebbe <[email protected]> Acked-by: Alexander Sverdlin <[email protected]> Tested-by: Alexander Sverdlin <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent d12c0aa commit 8b06260

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/i2c/i2c-core.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,9 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
567567
if (bri->prepare_recovery)
568568
bri->prepare_recovery(adap);
569569

570+
bri->set_scl(adap, val);
571+
ndelay(RECOVERY_NDELAY);
572+
570573
/*
571574
* By this time SCL is high, as we need to give 9 falling-rising edges
572575
*/
@@ -597,7 +600,6 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
597600

598601
int i2c_generic_scl_recovery(struct i2c_adapter *adap)
599602
{
600-
adap->bus_recovery_info->set_scl(adap, 1);
601603
return i2c_generic_recovery(adap);
602604
}
603605
EXPORT_SYMBOL_GPL(i2c_generic_scl_recovery);

0 commit comments

Comments
 (0)