net: ethernet: microchip: lan743x: Fix driver crash when lan743x_pm_resume fails

microchip1 · ksacilotto · commit 699d80b5abaf · 2022-01-13T17:56:00.000+01:00
BugLink: https://bugs.launchpad.net/bugs/1952785 commit d6423d2 upstream. The driver needs to clean up and return when the initialization fails on resume. Fixes: 23f0703 ("lan743x: Add main source files for new lan743x driver") Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3039,6 +3039,8 @@ static int lan743x_pm_resume(struct device *dev)
 	if (ret) {
 		netif_err(adapter, probe, adapter->netdev,
 			  "lan743x_hardware_init returned %d\n", ret);
+		lan743x_pci_cleanup(adapter);
+		return ret;
 	}
 
 	/* open netdev when netdev is at running state while resume.

Original file line number	Diff line number	Diff line change
`@@ -3039,6 +3039,8 @@ static int lan743x_pm_resume(struct device *dev)`
`3039`	`3039`	`if (ret) {`
`3040`	`3040`	`netif_err(adapter, probe, adapter->netdev,`
`3041`	`3041`	`"lan743x_hardware_init returned %d\n", ret);`
	`3042`	`+ lan743x_pci_cleanup(adapter);`
	`3043`	`+ return ret;`
`3042`	`3044`	`}`
`3043`	`3045`
`3044`	`3046`	`/* open netdev when netdev is at running state while resume.`