Skip to content

Commit 499fcc5

Browse files
committed
Stop consuming adoptopenjdk, bpftrace, bcc, fio, gdb-python and mold from internal sources in favor of upstream packages for LTS upgrade
PR URL: https://www.github.com/delphix/linux-pkg/pull/325
1 parent 8f9b7b5 commit 499fcc5

File tree

13 files changed

+7
-308
lines changed

13 files changed

+7
-308
lines changed

.github/scripts/verify-query-packages.sh

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ read -r -a fields <<<"$(./query-packages.sh single -o git-url zfs 2>&1)"
3030
test ${#fields[@]} -eq 1
3131
test "${fields[0]}" == 'https://github.com/delphix/zfs.git'
3232

33-
# Expect: "bpftrace bcc true https://github.com/delphix/bpftrace.git"
34-
read -r -a fields <<<"$(./query-packages.sh single -o name,dependencies,can-update,git-url bpftrace 2>&1)"
35-
test ${#fields[@]} -eq 4
36-
test "${fields[0]}" == 'bpftrace'
37-
test "${fields[1]}" == 'bcc'
38-
test "${fields[2]}" == 'true'
39-
test "${fields[3]}" == 'https://github.com/delphix/bpftrace.git'
40-
4133
# Expect that "list all" outputs all directory names under packages/
4234
diff <(ls -1 packages | sort) <(./query-packages.sh list all 2>&1 | sort)
4335

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -280,12 +280,7 @@ of some of the scripts defined above.
280280

281281
* **package_S3_URL**: Similar to the package_VAR variables above. This is used
282282
to override the default S3 location for where package build-dependencies are
283-
fetched for a given linux-pkg package. For instance, if you are building
284-
bpftrace, which has `PACKAGE_DEPENDENCIES="bcc"` in its config, the
285-
`fetch_dependencies()` stage in the build will fetch the latest build
286-
artifacts of the bcc package from a predetermined S3 location. If you pass
287-
`BCC_S3_URL=s3://path/to/custom/bcc/artifacts` then those artifacts will be
288-
fetched insteasd.
283+
fetched for a given linux-pkg package.
289284

290285
* **DELPHIX_PACKAGE_MIRROR_MAIN, DELPHIX_PACKAGE_MIRROR_SECONDARY**: When
291286
the [setup.sh](#setupsh) script is run, it will configure the apt sources

package-lists/build/main.pkgs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
# List of non-kernel packages to be included in the Delphix Appliance.
33
#
44

5-
adoptopenjdk
6-
bcc
7-
bpftrace
85
challenge-response
96
cloud-init
107
crash-python
@@ -16,17 +13,14 @@ delphix-sso-app
1613
drgn
1714
docker-python-image
1815
dwarves
19-
fio
2016
fluentd-gems
21-
gdb-python
2217
grub2
2318
host-jdks
2419
libkdumpfile
2520
make-jpkg
2621
makedumpfile
2722
masking
2823
misc-debs
29-
mold
3024
nfs-utils
3125
performance-diagnostics
3226
ptools

packages/adoptopenjdk/config.sh

Lines changed: 0 additions & 81 deletions
This file was deleted.

packages/bcc/config.sh

Lines changed: 0 additions & 39 deletions
This file was deleted.

packages/bpftrace/config.sh

Lines changed: 0 additions & 42 deletions
This file was deleted.

packages/containerized-masking/config.sh

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,19 @@ source "$PWD/lib/common.sh"
2929

3030
DEFAULT_PACKAGE_GIT_URL="https://github.com/delphix/dms-core-gate.git"
3131

32-
PACKAGE_DEPENDENCIES="adoptopenjdk"
3332
SKIP_COPYRIGHTS_CHECK=true
3433

3534
function prepare() {
36-
logmust install_pkgs "$DEPDIR"/adoptopenjdk/*.deb
35+
echo "Nothing to prepare"
3736
}
3837

3938
function build() {
40-
export JAVA_HOME
41-
JAVA_HOME=$(cat "$DEPDIR/adoptopenjdk/JDK_PATH") ||
42-
die "Failed to read $DEPDIR/adoptopenjdk/JDK_PATH"
43-
4439
logmust cd "$WORKDIR/repo"
4540

4641
local args=()
4742

4843
set_secret_build_args
44+
args+=("-Dorg.gradle.java.home=/lib/jvm/java-8-openjdk-amd64/")
4945
args+=("${_SECRET_BUILD_ARGS[@]}")
5046

5147
args+=("-Porg.gradle.configureondemand=false")

packages/delphix-sso-app/config.sh

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,13 @@
1717
# shellcheck disable=SC2034
1818

1919
DEFAULT_PACKAGE_GIT_URL="https://github.com/delphix/saml-app.git"
20-
PACKAGE_DEPENDENCIES="adoptopenjdk"
2120

2221
function prepare() {
23-
logmust install_pkgs "$DEPDIR"/adoptopenjdk/*.deb
22+
echo "Nothing to prepare"
2423
}
2524

2625
function build() {
27-
local java_home
28-
java_home=$(cat "$DEPDIR/adoptopenjdk/JDK_PATH") ||
29-
die "Failed to read $DEPDIR/adoptopenjdk/JDK_PATH"
3026
logmust cd "$WORKDIR/repo"
31-
logmust sudo ./gradlew "-Dorg.gradle.java.home=$java_home" distDeb
27+
logmust sudo ./gradlew distDeb
3228
logmust sudo mv ./build/distributions/*deb "$WORKDIR/artifacts/"
3329
}

packages/fio/config.sh

Lines changed: 0 additions & 41 deletions
This file was deleted.

packages/gdb-python/config.sh

Lines changed: 0 additions & 27 deletions
This file was deleted.

packages/masking/config.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,13 @@
1919
source "$PWD/lib/common.sh"
2020

2121
DEFAULT_PACKAGE_GIT_URL="https://github.com/delphix/dms-core-gate.git"
22-
PACKAGE_DEPENDENCIES="adoptopenjdk"
2322

2423
function prepare() {
2524
logmust read_list "$WORKDIR/repo/packaging/build-dependencies"
2625
logmust install_pkgs "${_RET_LIST[@]}"
27-
28-
logmust install_pkgs "$DEPDIR"/adoptopenjdk/*.deb
2926
}
3027

3128
function build() {
32-
export JAVA_HOME
33-
JAVA_HOME=$(cat "$DEPDIR/adoptopenjdk/JDK_PATH") ||
34-
die "Failed to read $DEPDIR/adoptopenjdk/JDK_PATH"
35-
3629
logmust cd "$WORKDIR/repo"
3730

3831
#
@@ -51,6 +44,7 @@ function build() {
5144
local args=()
5245

5346
set_secret_build_args
47+
args+=("-Dorg.gradle.java.home=/lib/jvm/java-8-openjdk-amd64/")
5448
args+=("${_SECRET_BUILD_ARGS[@]}")
5549

5650
args+=("-Porg.gradle.configureondemand=false")

0 commit comments

Comments
 (0)