Skip to content

Commit e87b40c

Browse files
committed
Add more documentation and refine github action
1 parent ffe9a87 commit e87b40c

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

.github/workflows/descript-build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: descript build test
1+
name: build shared-libs for Descript
22

33
on:
44
push:
@@ -9,7 +9,7 @@ on:
99

1010
jobs:
1111
build-macos-shared:
12-
name: build in native macOS
12+
name: ffmpeg-ffprobe-shared-darwin
1313
runs-on: macos-latest
1414
steps:
1515
- name: Checkout code
@@ -20,6 +20,6 @@ jobs:
2020
with:
2121
python-version: 3.8 #install the python needed
2222

23-
- name: execute py script # run the run.py to get the latest data
23+
- name: build-ffmpeg-descript.py
2424
run: |
2525
python ./descript/build-ffmpeg-descript.py

descript/README.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
![](../ffmpeg-build-script.png)
2+
13
# Build FFmpeg for Descript
24

35
## Author / Contact:
@@ -23,8 +25,22 @@ The build script automates the following basic operations.
2325

2426
## Development
2527
Known issues:
26-
- .
28+
- CI can only build `x86_64` and doesn't yet cross-compile to `arm64`
29+
- When running on CI, there's libraries linked from `/usr/local/opt/...` which are non-portable
30+
- Watch the script output at the end for warnings about this. These could turn into errors later.
2731

2832
## Patches
33+
- The build-ffmpeg shell script is modified directly to allow for
34+
- building shared libraries
35+
- disable non-free codecs
36+
- add additional codecs that Descript uses
2937

38+
## Deployment / Releases
39+
- Currently, the script is run manually on a developer's machine
40+
- once for each platform (`x86_64` and `arm64`)
41+
- Build artifacts (`*.zip` files) are manually uploaded to a GitHub release and tagged
42+
- `SHAMSUM256.txt` files need to be merged between the two platforms when adding to a release.
3043

44+
## Clients
45+
- This build is consumed by Descript's Beamcoder fork
46+
- https://github.com/descriptinc/beamcoder

0 commit comments

Comments
 (0)