Skip to content

Testing #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tunnckoCore opened this issue Feb 28, 2017 · 13 comments
Closed

Testing #40

tunnckoCore opened this issue Feb 28, 2017 · 13 comments

Comments

@tunnckoCore
Copy link
Collaborator

Isn't just enough to not use babel and etc? Why we need this and ES6 syntax and imports at all. It is just overhead. With that we can just remove babel from deps and they will look more clean.

/cc @developit

@developit
Copy link
Owner

developit commented Feb 28, 2017

@tunnckoCore maybe we can just drop Babel and switch from babel-register to buble/register? (example)

The tests aren't async (and likely don't ever need to be), so bublé should be enough for them.

@tunnckoCore
Copy link
Collaborator Author

tunnckoCore commented Feb 28, 2017

Don't know if buble has register, but don't see fit they to be ES6 et al ;d needless more dev time, but that's self preference.

edit: damn me, didn't clicked the example link. So yea, we can move to it.

@tunnckoCore
Copy link
Collaborator Author

@developit, actually no, we can just use buble/register, because Buble itself does not understand import/exports. rollup/rollup#657 (comment)

If we change them to use require()s, we totally can just use plain node. We don't have strong need to be ES6.

@tunnckoCore
Copy link
Collaborator Author

Meh.. currently I don't see any easy switch - followed few threads but not seems better than current approach with babel and tons of devDeps. As I'm building @rolldown and Muka v1 i can come with a solution for better testing and config around that ecosystem and not using Babel, AVA or such.

@tunnckoCore tunnckoCore added the can't Out of scope / too large / too seldom-used label Feb 28, 2017
@developit
Copy link
Owner

Buble and switching to requires seems decent enough.

@tunnckoCore
Copy link
Collaborator Author

if we switch to requires not make sense to use buble et al since we run tests only on node 6

@developit
Copy link
Owner

true, node 6 has arrow functions right? that's all I cared about

@tunnckoCore
Copy link
Collaborator Author

Yea, exactly. So we can just switch to requires and remove the whole test build overhead, just using mocha and arrows.

@developit
Copy link
Owner

developit commented Mar 7, 2017

I'm not against that, if you're up for it. Nice to drop the babel dep given it was only for testing.
I guess another option would be Ava where it's bundled in.

or you know, we write a 500b test framework

@tunnckoCore
Copy link
Collaborator Author

cool, i'll do that in a free time.

or you know, we write a 500b test framework

haha, yea. actually pretty easy idea btw, for around mid 2017 or early 2018 when everything is ES6 (or at least node v4). also i'm working on minimal framework too ;p

@developit
Copy link
Owner

developit commented Mar 7, 2017

wondering if rollup (or something) could be used to speed things up (for a tiny test fw)

@tunnckoCore
Copy link
Collaborator Author

tunnckoCore commented Mar 7, 2017

yeap, the cli of that small fw would run through rollup ;p thats on my todo and is in process :))

edit: actually mentioned rolldown project, so presets and plus import/export support included. kinda how ava works under the hood

@tunnckoCore tunnckoCore added beginner-friendly enhancement and removed can't Out of scope / too large / too seldom-used question labels Mar 7, 2017
@nmakod
Copy link

nmakod commented Jun 2, 2021

@developit , @tunnckoCore , I think this issue is no longer relevant and can be closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants