Skip to content

Research Using React-Hot-Loader #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devloco opened this issue Aug 14, 2019 · 2 comments
Closed

Research Using React-Hot-Loader #25

devloco opened this issue Aug 14, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@devloco
Copy link
Owner

devloco commented Aug 14, 2019

This looks like the latest work:
facebook/create-react-app#5958

And here's the doc site:
http://gaearon.github.io/react-hot-loader/

@devloco devloco self-assigned this Aug 14, 2019
@devloco devloco added the enhancement New feature or request label Aug 14, 2019
@benjaminviaud
Copy link

Hello,

I come with you to know if you have implement the React Hot Loader or if you say me how to implement it ? I try to use it but it doesn't work.

image

Thanks for your work.

Ben

@devloco
Copy link
Owner Author

devloco commented Jan 24, 2020

Hi @benjaminviaud,

It looks like react-hot-loader is obsolete now, replaced by Fast Refresh. See this post:

How should we set up apps for HMR now that Fast Refresh replaces react-hot-loader?

In particular, see Dan Abramov's comment on that post:
facebook/react#16604 (comment)

And, purely my opinion here, but I've used react-hot-loader in other projects, and I don't like it at all. It's untrustworthy. You always need a full browser refresh to be absolutely sure what you're seeing on screen is what your visitors/customers will see when the project is deployed. And once I realized that I was always manually refreshing anyway, I've never used it again.

I'm sure it makes for a cool demo. But for getting work done, I avoid it.

Anyway, if Facebook ever officially adds support for Fast Refresh (or any other tool), then Create React WPTheme will also get that feature (At this point create-react-wptheme is using a copy of the webpack.config.js file used by create-react-app with only the smallest changes (e.g. support for PHP files, etc.)).

@devloco devloco closed this as completed Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants