Skip to content

Commit 2efea52

Browse files
committed
Refine test patterns to avoid spurious matches
Intermittent test failures were observed as "1005" happend to match the version string in CBMC version 5.9 (cbmc-5.9-1005-g2c1f35e2) 64-bit x86_64 linux
1 parent aa7ebbc commit 2efea52

File tree

6 files changed

+26
-26
lines changed

6 files changed

+26
-26
lines changed

jbmc/regression/jbmc/reachability-slice/test.desc

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
CORE symex-driven-lazy-loading-expected-failure
22
A.class
33
--reachability-slice --show-goto-functions --property 'java::A.foo:(I)V.coverage.3' --cover location
4-
1001
4+
= \(int\)\(short\)1001
55
--
6-
1003
7-
1004
8-
1005
6+
= \(int\)\(short\)1003
7+
= \(int\)\(short\)1004
8+
= \(int\)\(short\)1005
99
--
1010
Note: 1002 might and might not be removed, based on where the assertion for coverage resides.
1111
At the time of writing of this test, 1002 is removed.
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
CORE symex-driven-lazy-loading-expected-failure
22
A.class
33
--reachability-slice-fb --show-goto-functions --property 'java::A.foo:(I)V.coverage.4' --cover location
4-
1001
5-
1002
6-
1003
7-
1005
4+
= \(int\)\(short\)1001
5+
= \(int\)\(short\)1002
6+
= \(int\)\(short\)1003
7+
= \(int\)\(short\)1005
88
--
9-
1004
9+
= \(int\)\(short\)1004
1010
--
1111
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
CORE symex-driven-lazy-loading-expected-failure
22
A.class
33
--reachability-slice --show-goto-functions --cover location
4-
1001
5-
1002
6-
1003
7-
1004
8-
1005
4+
= \(int\)\(short\)1001
5+
= \(int\)\(short\)1002
6+
= \(int\)\(short\)1003
7+
= \(int\)\(short\)1004
8+
= \(int\)\(short\)1005
99
--
1010
--
1111
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
CORE
22
test.c
33
--reachability-slice --show-goto-functions --cover location --property foo.coverage.2
4-
1001
4+
= 1001
55
--
6-
1004
7-
1005
6+
= 1004
7+
= 1005
88
--
99
We do not include 1002 and 1003, whether this is hit depends on where assertion is put
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
CORE
22
test.c
33
--reachability-slice-fb --show-goto-functions --cover location --property foo.coverage.2
4-
1001
5-
1002
6-
1003
7-
1005
4+
= 1001
5+
= 1002
6+
= 1003
7+
= 1005
88
--
9-
1004
9+
= 1004
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
CORE
22
test.c
33
--reachability-slice --show-goto-functions --cover location
4-
1001
5-
1002
6-
1003
7-
1004
4+
= 1001
5+
= 1002
6+
= 1003
7+
= 1004
88
--
99
--
1010
We do not include 1005 since it might or might not be present based on where the assertion is in the block.

0 commit comments

Comments
 (0)